docs: fix stale contribution and e2e debug instructions#9154
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: immanuwell The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @immanuwell. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9154 +/- ##
=======================================
Coverage 51.04% 51.05%
=======================================
Files 411 411
Lines 22132 22132
=======================================
+ Hits 11298 11300 +2
+ Misses 9960 9959 -1
+ Partials 874 873 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
A couple contributor docs are stale and trip people up a bit.
hack/README.mdstill points atmasterand usesgit co, which fails on a normal git setup.DEVELOPMENT.mdalso points totest/rekt/scenariosand mentionsTestMyRektScenario, but neither matches this repo.How to repro
git co -b my-backport-branch upstream/release-X.Ygit: 'co' is not a git commandgit symbolic-ref refs/remotes/origin/HEADand seerefs/remotes/origin/maintest -d test/rekt/scenarios || echo missingrg 'TestPingSourceWithSinkRef|TestMyRektScenario' test/rekt test -SFix is pretty small: use
main, switchgit cotogit checkout, and align thee2e-debug.shexample with the real test and path. Tiny cleanup, but saves a weird faceplant