Add --registry-authfile to specify a specific auth file for the registry push by creydr · Pull Request #3208 · knative/func

creydr · 2025-11-19T11:03:31Z

Changes

🎁 Adding the --registry-authfile string build parameter to allow to specify a custom registry auth file location

/kind enhancement

Release Note

Add the --registry-authfile build parameter to allow to specify a custom registry auth file location

codecov · 2025-11-19T11:09:56Z

Codecov Report

❌ Patch coverage is 94.54545% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.55%. Comparing base (b039190) to head (ee37f59).
⚠️ Report is 19 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/client.go	62.50%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3208      +/-   ##
==========================================
+ Coverage   51.81%   54.55%   +2.74%     
==========================================
  Files         162      162              
  Lines       19131    19216      +85     
==========================================
+ Hits         9912    10484     +572     
+ Misses       8241     7688     -553     
- Partials      978     1044      +66

Flag	Coverage Δ
e2e	`39.68% <88.88%> (?)`
e2e go	`35.61% <88.88%> (?)`
e2e node	`30.98% <88.88%> (?)`
e2e python	`35.34% <77.77%> (?)`
e2e quarkus	`31.14% <88.88%> (?)`
e2e rust	`30.55% <77.77%> (?)`
e2e springboot	`30.61% <77.77%> (?)`
e2e typescript	`31.10% <88.88%> (?)`
integration	`17.90% <0.00%> (+0.01%)`	⬆️
unit macos-14	`44.33% <95.55%> (-0.05%)`	⬇️
unit macos-latest	`44.33% <95.55%> (-0.05%)`	⬇️
unit ubuntu-24.04-arm	`44.53% <94.54%> (-0.04%)`	⬇️
unit ubuntu-latest	`45.26% <95.55%> (-0.05%)`	⬇️
unit windows-latest	`44.35% <95.55%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

creydr · 2025-11-19T14:10:21Z

/hold
need to verify with remote deploy

creydr · 2025-11-19T14:38:13Z

/unhold

creydr · 2025-11-20T11:42:16Z

/test ?

knative-prow · 2025-11-20T11:42:19Z

@creydr: The following commands are available to trigger required jobs:

/test unit-tests

Use /test all to run all jobs.

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

creydr · 2025-11-20T11:43:02Z

/retest

lkingland

👍🏻 Nice

Can we make this change to the oci.Pusher as well, so that it works withe the Host builder (and for users with no docker/podman available)? They're all using the creds package, so I assume this could work for both pushers.

Also, if you rebase on main you'll get some improved E2E tests.

…try push

creydr · 2025-11-21T07:12:08Z

👍🏻 Nice

Can we make this change to the oci.Pusher as well, so that it works withe the Host builder (and for users with no docker/podman available)? They're all using the creds package, so I assume this could work for both pushers.

Also, if you rebase on main you'll get some improved E2E tests.

Hey @lkingland,
I added / reinitialized the pusher in the build.go clientOptions() with the credentials provider for host,pack,s2i builders (see https://github.com/creydr/knative-func/blob/2f563bfd250c78850f7b1fc61b232880cc1f3178/cmd/build.go#L498), as we there had the registry-authfile flag parsed. Or do you mean something different?

creydr · 2025-11-21T07:35:30Z

Rebased. Tests seem to pass now again

creydr · 2025-11-21T10:04:41Z

/cc @lkingland @gauron99

creydr · 2025-11-25T12:08:11Z

@lkingland @gauron99 can you recheck?

twoGiants

Looks good 😸 👍

Found only minor things in the test. See comments below.

twoGiants · 2025-11-25T16:20:55Z

pkg/creds/credentials_test.go

+				t.Fatalf("failed to create temp auth file: %s", err)
+			}
+			t.Cleanup(func() {
+				os.Remove(authFile.Name())


You could use t.TempDir and create the file there. Then you would not need to cleanup as the temp dir is removed automatically.

Good point. Updated it

twoGiants · 2025-11-25T16:23:15Z

pkg/creds/credentials_test.go

+			// ASSERT
+			if err != nil {
+				t.Errorf("%v", err)
+				return
+			}


Suggested change

// ASSERT

if err != nil {

t.Errorf("%v", err)

return

}

if err != nil {

t.Fatalf("unexpected error: %v", err)

}

This can probably updated in few more tests in this file.

👍 Updated it

twoGiants · 2025-11-25T16:28:04Z

pkg/creds/credentials_test.go

+
 // ********************** helper functions below **************************** \\

 func resetHomeDir(t *testing.T) {


Right below that line in 906 is t.TempDir() which probably should be t.Helper(). And the function right below resetHomePermissions is missing the t.Helper() too.

twoGiants

Looks great! 😸 👍

creydr · 2025-11-26T09:22:30Z

/assign @gauron99 @lkingland

gauron99 · 2025-11-26T09:50:28Z

/lgtm
/approve

knative-prow · 2025-11-26T09:50:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [gauron99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knative-prow bot added the kind/enhancement label Nov 19, 2025

knative-prow bot requested review from dsimansk and jrangelramos November 19, 2025 11:03

knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 19, 2025

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2025

creydr force-pushed the add-registry-authfile-build-option branch 2 times, most recently from ba236bd to a1e3e31 Compare November 20, 2025 10:30

lkingland reviewed Nov 21, 2025

View reviewed changes

creydr added 3 commits November 21, 2025 08:06

Add --registry-authfile to specify a specific auth file for the regis…

3994999

…try push

Add option to deploy command too

df4fcd7

Run hack/update-codegen.sh

2f563bf

creydr force-pushed the add-registry-authfile-build-option branch from a1e3e31 to 2f563bf Compare November 21, 2025 07:06

knative-prow bot requested review from gauron99 and lkingland November 21, 2025 10:04

twoGiants approved these changes Nov 25, 2025

View reviewed changes

knative-prow bot assigned twoGiants Nov 25, 2025

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2025

creydr added 2 commits November 26, 2025 07:24

Use t.TempDir() to create temporary authfile in

a3eb497

Use t.Fatalf() instead of t.Errorf() with a return

514d977

knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025

Marked some helper functions with t.Helper()

ee37f59

creydr requested a review from twoGiants November 26, 2025 06:28

twoGiants approved these changes Nov 26, 2025

View reviewed changes

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025

knative-prow bot assigned gauron99 and lkingland Nov 26, 2025

knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025

knative-prow bot merged commit 5d86d20 into knative:main Nov 26, 2025
42 checks passed


		// ******************** helper functions below ************************** \\

		func resetHomeDir(t *testing.T) {

Conversation

creydr commented Nov 19, 2025

Changes

Uh oh!

codecov bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

creydr commented Nov 19, 2025

Uh oh!

creydr commented Nov 19, 2025

Uh oh!

creydr commented Nov 20, 2025

Uh oh!

knative-prow bot commented Nov 20, 2025

Uh oh!

creydr commented Nov 20, 2025

Uh oh!

lkingland left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

creydr commented Nov 21, 2025

Uh oh!

creydr commented Nov 21, 2025

Uh oh!

creydr commented Nov 21, 2025

Uh oh!

creydr commented Nov 25, 2025

Uh oh!

twoGiants left a comment

Choose a reason for hiding this comment

Uh oh!

twoGiants Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

creydr Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

twoGiants Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

twoGiants Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

creydr Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

twoGiants Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

creydr Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

twoGiants left a comment

Choose a reason for hiding this comment

Uh oh!

creydr commented Nov 26, 2025

Uh oh!

gauron99 commented Nov 26, 2025

Uh oh!

knative-prow bot commented Nov 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Nov 19, 2025 •

edited

Loading

lkingland left a comment •

edited

Loading