feat: unhide username/password/token flags for all builders#3420
feat: unhide username/password/token flags for all builders#3420Kunal1522 wants to merge 1 commit intoknative:mainfrom
Conversation
|
@Kunal1522: The label(s) DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @Kunal1522. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3420 +/- ##
==========================================
- Coverage 54.74% 54.59% -0.16%
==========================================
Files 173 179 +6
Lines 20112 20214 +102
==========================================
+ Hits 11011 11036 +25
- Misses 7992 8008 +16
- Partials 1109 1170 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Since PR knative#3298 fixed these credentials to work with all builders (host, pack, s2i), there's no reason to keep them hidden anymore. Also added environment variable hints to flag descriptions.
fd4ec90 to
2cade19
Compare
|
/ok-to-test |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, Kunal1522 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold to wait on @matejvasek @lkingland review |
Since PR #3298 fixed these credentials to work with all builders (host, pack, s2i), there's no reason to keep them hidden anymore.
Fixes #3299