refactor: replace UMD with CJS, fix exports map, and bump to v1.2.9#39
Merged
Conversation
Remove the duplicate .mjs ESM output and replace the UMD dist with a dedicated CJS build. Remove the "browser" condition from the exports map, which caused default imports to resolve as undefined in browser-targeted resolvers such as Webpack 5 and Rollup (closes #38).
Update jsdom to ^29.1.1, rollup to ^4.61.1, and vitest to ^4.1.8. Add allowScripts configuration for fsevents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/cjs/jquery-param.cjs).mjsESM artifact;dist/esm/jquery-param.jsis now the sole ESM entry"browser"condition from theexportsmap, which caused default imports to resolve asundefinedin browser-targeted resolvers such as Webpack 5 and Rollup (closes mismatch between type: "module" and UMD exports.browser mapping #38)Commits
refactor: replace UMD output with CJS and simplify ESM artifactschore: bump version to 1.2.9 and update dev dependenciesTest plan
npm run buildcompletes without errors and generatesdist/esm/jquery-param.js,dist/cjs/jquery-param.cjs, andjquery-param.min.jsnpm testpasses all test casesrequire('jquery-param')resolves correctly via the CJS entryimport param from 'jquery-param'resolves correctly via the ESM entry