fix(overflow-items,actions-panel): flaky visibility recalculations (#DS-5130)#1634
fix(overflow-items,actions-panel): flaky visibility recalculations (#DS-5130)#1634artembelik wants to merge 5 commits into
Conversation
🚨 E2E tests failedReview the report for details. 💡 Comment |
|
Visit the preview URL for this PR (updated for commit ad28e0b): https://koobiq-next--prs-1634-goffw1yo.web.app (expires Sat, 20 Jun 2026 14:25:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
There was a problem hiding this comment.
Pull request overview
This PR addresses flaky overflow/visibility recalculations in KbqOverflowItems (and a related KbqActionsPanel overlay-container sizing case) by changing how available space is measured and by expanding unit/e2e coverage for resize-driven recalculation scenarios.
Changes:
- Switched overflow measurement to
getBoundingClientRect()and captured available container size once per recalculation to avoid circular shrink/hide feedback loops. - Added/expanded unit tests and Playwright e2e scenarios covering orientation changes, debounce behavior, dynamic items, left-margin sizing, and additional resize-observer targets.
- Refactored
KbqActionsPaneloverlay max-width syncing into a helper and added resize-related e2e/spec coverage.
Reviewed changes
Copilot reviewed 7 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/components/overflow-items/overflow-items.ts | Updates sizing logic and stabilizes the hide-loop by snapshotting available size. |
| packages/components/overflow-items/overflow-items.spec.ts | Adds unit coverage for resize-observer targets, debounce, orientation changes, and visibility manager behavior. |
| packages/components/overflow-items/e2e.ts | Adds new e2e demo scenarios (margin-left, debounce, additional targets, dynamic add/remove). |
| packages/components/overflow-items/e2e.playwright-spec.ts | Adds Playwright coverage for live resize, debounce, additional targets, margins, vertical alwaysVisible edge cases, and dynamic items. |
| packages/components/actions-panel/actions-panel.ts | Extracts max-width syncing and applies it before subscribing to resize updates. |
| packages/components/actions-panel/actions-panel.spec.ts | Adds tests for array class inputs, default config provider, open-twice behavior, and overlayContainer maxWidth syncing. |
| packages/components/actions-panel/e2e.playwright-spec.ts | Adds dark-theme screenshot coverage and a new container-resize overflow behavior test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/approve-snapshots |
|
🔄 Updating snapshots. |
|
🚨 Failed to update snapshots. |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
🚨 E2E tests failedReview the report for details. 💡 Comment |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
🚨 E2E tests failedReview the report for details. 💡 Comment |
No description provided.