Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR proofreads Chapter 1 of the getting-started book section to improve readability, consistency, and phrasing.
Changes:
- Rewrites the chapter description and multiple paragraphs for clarity and concision.
- Normalizes heading capitalization and adjusts instructional phrasing throughout.
- Improves grammar and flow in the quickstart/customization/apply/update/cleanup sections.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
documentation/content/en/book/01-getting-started/_index.md:20
- The text says to "Install" the kpt CLI using
kpt version, butkpt versiononly verifies an existing installation. Consider rephrasing to something like "After installing the kpt CLI, verify it by running…" or update the command to an actual install step.
Install the [kpt CLI](installation/kpt-cli), using the following command:
```shell
kpt version
</details>
---
💡 <a href="/kptdev/kpt/new/main?filename=.github/instructions/*.instructions.md" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href="https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot" class="Link--inTextBlock" target="_blank" rel="noopener noreferrer">Learn how to get started</a>.<br><br>You can also share your feedback on Copilot code review. [Take the survey](https://www.surveymonkey.com/r/XP6L3XJ).
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
Signed-off-by: Michael Greaves <michael.greaves@nokia.com>
ca29d07 to
7db9d3a
Compare
| Install the [kpt CLI](installation/kpt-cli): | ||
| Install the [kpt CLI](installation/kpt-cli), using the following command: | ||
|
|
||
| ```shell | ||
| kpt version | ||
| ``` | ||
|
|
There was a problem hiding this comment.
That is not the installation command, but to check if you have it installed.
| ``` | ||
|
|
||
| As you can see, this package contains 3 resources in 3 files. There is a special file named `Kptfile` which is used by | ||
| As can be seen, this package contains three resources in three files. There is a special file named `Kptfile`. This file is used by |
There was a problem hiding this comment.
"As can be seen" sounds a little archaic to me.
I don't think we should split "...special file named Kptfile which is used by..." into two different sentences.
|
|
||
| You might want to label all resources in the package. To achieve that, you can declare `set-labels` function in the | ||
| `pipeline` section of `Kptfile`. Add this by running the following command: | ||
| It might be a good idea to label all the resources in the package. To achieve this, you can declare the `set-labels` function, in the |
There was a problem hiding this comment.
| It might be a good idea to label all the resources in the package. To achieve this, you can declare the `set-labels` function, in the | |
| It might be a good idea to label all the resources in the package. To achieve this, you can declare the `set-labels` function in the |
| Congrats! You should now have a rough idea of what kpt is and what you can do | ||
| with it. Now, let's delve into the details. | ||
| You should now have a rough idea of what kpt is and what you can do | ||
| with it. Let us now delve into the details. |
There was a problem hiding this comment.
I agree with copilot here, "let us now" sounds too formal IMO.
No description provided.