fix: useViewportScrollCoords & useViewportScale fall back properly#269
Open
DougReeder wants to merge 1 commit intokripod:masterfrom
Open
fix: useViewportScrollCoords & useViewportScale fall back properly#269DougReeder wants to merge 1 commit intokripod:masterfrom
DougReeder wants to merge 1 commit intokripod:masterfrom
Conversation
DougReeder
commented
Oct 4, 2021
DougReeder
commented
- Both hooks fall back properly when window.visualViewport isn't defined (as in jsdom when running tests, or an old browser)
- useViewportScale falls back to 1.0 rather than 0
- useViewportScrollCoords also updates on resize events resize
Author
|
I don't know why the Build Errored, but it builds fine and the tests pass for me, using node 14.16.1 under MacOS 11.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.