Conversation
printf "%(%Y-%m-%d)T\n" "now in 10 week"
produce
2025-11-13
This fix produce the expecteed
2026-01-22
src/lib/libast/tm/tmxdate.c::1456
case TM_PARTS+4:
tm = tmxtm(tm, tmxtime(tm, zone), tm->tm_zone, 0);
tm->tm_hour += m * 7 * 24;
set |= DAY; <======= TYPO HERE
goto clear_hour;
Since we are updating tm_hour then set HOUR
|
It still seems very buggy. Today is 2026-01-22. So far, so good. But: None of that makes any sense, does it? |
Author
|
@McDutchie Yes it was very very buggy and now it is very buggy, I doubt anyone use that. Yet it is still possible to do the math the right way $((...)) arith instead of the cobol like "now in 10 weeks". The following shows how to get 'now" then add up whatever formula you need. Use this as a workaround until someone fix this bug... |
Author
|
@McDutchie Welcome back by the way :-) |
|
Thanks. :) I can't easily think of a regression test since the result changes by the day, so I'll just merge this now. |
McDutchie
pushed a commit
that referenced
this pull request
Jan 28, 2026
The referenced commit introduced a bug:
printf "%(%Y-%m-%d)T\n" "now in 10 week"
printf "%(%Y-%m-%d)T\n" "in 10 weeks"
produce today's date.
As of this fix, they produce the date in ten weeks.
src/lib/libast/tm/tmxdate.c::1456
case TM_PARTS+4:
tm = tmxtm(tm, tmxtime(tm, zone), tm->tm_zone, 0);
tm->tm_hour += m * 7 * 24;
set |= DAY; // <======= BUG HERE
goto clear_hour;
The fix: since we are updating tm_hour, set HOUR, not DAY.
Resolves: #915
McDutchie
pushed a commit
that referenced
this pull request
Jan 28, 2026
The referenced commit introduced a bug:
printf "%(%Y-%m-%d)T\n" "now in 10 week"
printf "%(%Y-%m-%d)T\n" "in 10 weeks"
produce today's date.
As of this fix, they produce the date in ten weeks.
src/lib/libast/tm/tmxdate.c::1456
case TM_PARTS+4:
tm = tmxtm(tm, tmxtime(tm, zone), tm->tm_zone, 0);
tm->tm_hour += m * 7 * 24;
set |= DAY; // <======= BUG HERE
goto clear_hour;
The fix: since we are updating tm_hour, set HOUR, not DAY.
Resolves: #915
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 1a9d8ad introduced a bug
printf "%(%Y-%m-%d)T\n" "now in 10 week"
produce
2025-11-13
This fix produce the expecteed
2026-01-22
src/lib/libast/tm/tmxdate.c::1456
case TM_PARTS+4:
tm = tmxtm(tm, tmxtime(tm, zone), tm->tm_zone, 0);
tm->tm_hour += m * 7 * 24;
set |= DAY; <======= TYPO HERE
goto clear_hour;
Since we are updating tm_hour then set HOUR