Fix fakeroot build by using od(1) to check 64-bit ELFs#943
Open
Fix fakeroot build by using od(1) to check 64-bit ELFs#943
Conversation
bin/package: - Use od(1) to check the ELF header if the file command fails. This allows ksh to build and install correctly in fakeroot environments without encountering bogus seccomp restrictions. Fixes ksh93#919
- Check the first five bytes to guarantee it's actually an ELF binary.
- Return 'Unknown bits' if it's neither a 64-bit ELF nor 32-bit ELF
(i.e. it could be anything). This isn't functionally different but is
better for clarity.
- Pass '-A n' to od(1) rather than '-An' for what should be better
portability.
- locale.sh: Also apply that change here since a quick grep showed
this file was also passing -An to od.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/package:
odto check the ELF header iffilefails with an error. This allows ksh to build and install correctly infakerootenvironments without encountering bogus seccomp restrictions.Fixes #919