Use NonEmpty and avoid unreachable code#1
Merged
kubaneko merged 2 commits intokubaneko:PageRankfrom Sep 7, 2022
ysangkok:janus/nonempty
Merged
Use NonEmpty and avoid unreachable code#1kubaneko merged 2 commits intokubaneko:PageRankfrom ysangkok:janus/nonempty
kubaneko merged 2 commits intokubaneko:PageRankfrom
ysangkok:janus/nonempty
Conversation
kubaneko
approved these changes
Sep 7, 2022
Owner
kubaneko
left a comment
kubaneko
left a comment
There was a problem hiding this comment.
Thank you, that makes sense.
I was not sure how to construct ItemIndex with NonEmpty so I forgot about it.
kubaneko
added a commit
that referenced
this pull request
Sep 18, 2022
Co-authored-by: Ondřej Kubánek <71923533+kubaneko@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for this comment: haskell#1091 (comment)