Skip to content

cert-manager: build crd-model-gen image locally in update.sh #4751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YuqiGuo105 wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −4
Open

cert-manager: build crd-model-gen image locally in update.sh #4751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions client-java-contrib/cert-manager/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ To use this library, include the following maven dependency
<dependency>
<groupId>io.kubernetes</groupId>
<artifactId>client-java-cert-manager-models</artifactId>
<version>0.16.1-SNAPSHOT</version>
<version>27.0.0-SNAPSHOT</version>
</dependency>
```
Please refer to the [CertManagerExample](../../examples/src/main/java/io/kubernetes/client/examples/CertManagerExample.java), which demonstrates how to create a self signed issuer using the model class and Kubernetes Java client generic API.
## Compatibility
Artifact Version|Cert-Manager Release Version|CRD Source
----------------|----------------------------|----------
0.16.1-SNAPSHOT|0.16.1|[Here](https://github.com/jetstack/cert-manager/releases/download/v0.16.1/cert-manager.crds.yaml)
27.0.0-SNAPSHOT|1.13.4|[Here](https://github.com/jetstack/cert-manager/releases/download/v1.13.4/cert-manager.crds.yaml)
## Code Generation
There is a utility script [update.sh](update.sh) to help with the code generation.

Expand Down
17 changes: 15 additions & 2 deletions client-java-contrib/cert-manager/update.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,24 @@
# This script generates the model classes from a released version of cert-manager CRDs
# under src/main/java/io/cert/manager/models.

DEFAULT_IMAGE_NAME=docker.pkg.github.com/kubernetes-client/java/crd-model-gen
DEFAULT_IMAGE_TAG=v2.0.0
# The crd-model-gen image used to be published to docker.pkg.github.com, which
# requires GitHub authentication and returns "Access is denied" for anonymous
# pulls (see kubernetes-client/java#3489). Build it locally from the Dockerfile
# in this repository instead, so the script works out of the box.
DEFAULT_IMAGE_NAME=local/crd-model-gen
DEFAULT_IMAGE_TAG=latest
IMAGE_NAME=${IMAGE_NAME:=$DEFAULT_IMAGE_NAME}
IMAGE_TAG=${IMAGE_TAG:=$DEFAULT_IMAGE_TAG}

# Build the crd-model-gen image locally if it is not already present, using the
# Dockerfile shipped in client-java-contrib/.
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
CONTRIB_DIR="$(cd "${SCRIPT_DIR}/.." && pwd)"
if ! docker image inspect "${IMAGE_NAME}:${IMAGE_TAG}" >/dev/null 2>&1; then
echo "Building ${IMAGE_NAME}:${IMAGE_TAG} from ${CONTRIB_DIR}/Dockerfile ..."
docker build -t "${IMAGE_NAME}:${IMAGE_TAG}" "${CONTRIB_DIR}"
fi

# a crdgen container is run in a way that:
# 1. it has access to the docker daemon on the host so that it is able to create sibling container on the host
# 2. it runs on the host network so that it is able to communicate with the KinD cluster it launched on the host
Expand Down