Skip to content

fix: handle empty error channel in returncode to prevent race condition #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kshiteej-mali wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −4
Open

fix: handle empty error channel in returncode to prevent race condition #2576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions kubernetes/base/stream/ws_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,12 +284,15 @@ def returncode(self):
else:
if self._returncode is None:
err = self.read_channel(ERROR_CHANNEL)
if not err:
return None
err = yaml.safe_load(err)
if err['status'] == "Success":
if err and err.get('status') == 'Success':
self._returncode = 0
else:
self._returncode = int(err['details']['causes'][0]['message'])
return self._returncode
elif err and err.get('status') == 'Failure':
self._returncode = int(
err['details']['causes'][0]['message']
)

def close(self, **kwargs):
"""
Expand Down