Skip to content

[pre-commit.ci] pre-commit autoupdate#552

Open
pre-commit-ci[bot] wants to merge 2 commits into
mainfrom
pre-commit-ci-update-config
Open

[pre-commit.ci] pre-commit autoupdate#552
pre-commit-ci[bot] wants to merge 2 commits into
mainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 03a9ac4 to 36a1afd Compare March 2, 2026 22:38
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 29f6467 to be87edc Compare April 6, 2026 22:29
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 3691939 to 33085c6 Compare May 4, 2026 21:41
updates:
- [github.com/psf/black-pre-commit-mirror: 25.11.0 → 26.5.1](psf/black-pre-commit-mirror@25.11.0...26.5.1)
- [github.com/pycqa/isort: 7.0.0 → 9.0.0a3](PyCQA/isort@7.0.0...9.0.0a3)
- [github.com/editorconfig-checker/editorconfig-checker: v3.6.0 → v3.7.0](editorconfig-checker/editorconfig-checker@v3.6.0...v3.7.0)
- [github.com/python-jsonschema/check-jsonschema: 0.35.0 → 0.37.2](python-jsonschema/check-jsonschema@0.35.0...0.37.2)
- [github.com/rhysd/actionlint: v1.7.9 → v1.7.12](rhysd/actionlint@v1.7.9...v1.7.12)
@pre-commit-ci pre-commit-ci Bot force-pushed the pre-commit-ci-update-config branch from 8e936e7 to 42fa237 Compare June 1, 2026 22:43
@gaoflow

gaoflow commented Jun 19, 2026

Copy link
Copy Markdown

I dug into the tox failures on this PR. The failures are confined to the *-chardet tox factors; the ordinary Python tox jobs are passing.

The failing jobs are installing the latest chardet (chardet==7.4.3 in the CI logs). That changes several detected encoding names compared with the versions this test suite expects, for example:

  • windows-1255 is reported as ISO-8859-8
  • GB2312 is reported as cp1250
  • SHIFT_JIS is reported as cp932
  • TIS-620 is reported as cp874
  • EUC-KR is reported as CP949

This looks unrelated to the pre-commit/rfc822 formatting changes in the PR. The chardet tox dependency currently floats to latest, so the CI result changed under the branch.

A minimal fix is to cap the chardet factor to the major version the current expectations are compatible with:

diff --git a/tox.ini b/tox.ini
index 3440a1b01..d75442946 100644
--- a/tox.ini
+++ b/tox.ini
@@ -57,7 +57,7 @@ extras =
 passenv = CI
 deps =
     -r requirements/test/requirements.txt
-    chardet: chardet
+    chardet: chardet<6
 commands =
     coverage run -m pytest {posargs:}

I verified the affected tests locally against the installed chardet==5.2.0:

PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 PYTHONPATH=. python -m pytest -q tests/test_ill_formed.py tests/test_encoding.py
# 219 passed in 0.19s

git diff --check
# no output

I could not run the full tox matrix in this environment because tox is not installed here and the runner is critically low on disk space, but the failing CI evidence points specifically at the floating chardet dependency. I do not have push access to this branch, so I am leaving the patch here for the branch owner to apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant