deps(lambda-rs-platform): Remove shaderc as a shader backend#109
Merged
deps(lambda-rs-platform): Remove shaderc as a shader backend#109
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the shaderc shader compilation backend from the lambda-rs codebase, simplifying the build process by eliminating external dependencies on cmake (>= 3.20.0) and ninja. The naga backend becomes the sole shader compilation backend.
Changes:
- Removed shaderc dependency and its build-from-source feature flags from Cargo.toml
- Removed the shaderc_backend.rs implementation file (~120 lines) and deprecated shaderc.rs module
- Updated documentation to reflect the simplified dependencies and single shader backend (naga)
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/features.md | Updated to remove shaderc backend documentation, bumped version to 0.1.6, and added changelog entry |
| crates/lambda-rs/src/render/shader.rs | Updated comment to reflect that only naga backend is now used |
| crates/lambda-rs/Cargo.toml | Removed with-shaderc and with-shaderc-build-from-source feature flags |
| crates/lambda-rs-platform/src/shaderc.rs | Removed deprecated shaderc module re-exports |
| crates/lambda-rs-platform/src/shader/shaderc_backend.rs | Removed entire shaderc backend implementation (~120 lines) |
| crates/lambda-rs-platform/src/shader/mod.rs | Simplified exports to only use naga backend, removed conditional compilation for shaderc |
| crates/lambda-rs-platform/src/lib.rs | Removed shaderc module from public API |
| crates/lambda-rs-platform/Cargo.toml | Removed shaderc dependency and shader-backend-shaderc feature flags |
| README.md | Removed cmake and ninja from required external dependencies |
| Cargo.lock | Removed cmake, shaderc, and shaderc-sys package entries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the shaderc shader compilation backend from the codebase, simplifying the build process and reducing external dependencies. The naga backend is now the sole shader compilation backend for lambda.
Related Issues
Changes
shaderc_backend.rsimplementation fileType of Change
Affected Crates
lambda-rslambda-rs-platformlambda-rs-argslambda-rs-loggingChecklist
cargo +nightly fmt --all)cargo clippy --workspace --all-targets -- -D warnings)cargo test --workspace)Testing
Commands run:
cargo build --workspace cargo test --workspaceManual verification steps (if applicable):
cargo run --example triangle)Screenshots/Recordings
Platform Testing
Additional Notes
Breaking Changes
Users who were explicitly using the following feature flags will need to update their configurations:
with-shaderc- No longer availablewith-shaderc-build-from-source- No longer availableshader-backend-shaderc- No longer availableshader-backend-shaderc-build-from-source- No longer availableBenefits
Migration
Projects using the shaderc backend should:
with-shadercorshader-backend-shadercfeature flags from their Cargo.tomlshader-backend-naga(default) is being used