feat: clean up transaction files on failed commits#6319
Open
wjones127 wants to merge 2 commits intolance-format:mainfrom
Open
feat: clean up transaction files on failed commits#6319wjones127 wants to merge 2 commits intolance-format:mainfrom
wjones127 wants to merge 2 commits intolance-format:mainfrom
Conversation
Previously, if a commit failed (OtherError or unresolvable conflict), the transaction file written to _transactions/ was left orphaned and would not be removed until GC ran after 7+ days. This adds best-effort cleanup: on any failure path in do_commit_new_dataset, do_commit_detached_transaction, and commit_transaction, the transaction file is deleted before the error is returned. Failures to delete are logged as warnings so they don't mask the original error. For commit_transaction, stale transaction files from previous retry iterations (which get rebased and re-written each attempt) are also cleaned up when we retry after a conflict. Closes lance-format#6125 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
wjones127
force-pushed
the
feat/cleanup-txn-files
branch
from
6c39d29 to
fd9fe41
Compare
The cleanup_failed_commit_data_file test expected 2 txn files after a failed append, but now the failed commit immediately cleans up its own txn file, leaving only 1. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a manifest commit failed (conflict, error, or retry exhaustion), the
.txnfile written to_transactions/was left orphaned. These files would accumulate until the GC cleanup interval (7+ days by default).This PR adds
cleanup_transaction_file()— a best-effort delete helper — and calls it from all three commit failure paths (do_commit_new_dataset,do_commit_detached_transaction,commit_transaction). Failures to delete are logged as warnings and do not surface to the caller.In the retry loop of
commit_transaction, the previous iteration's transaction file is cleaned up before each retry attempt, since a new transaction file is written on each iteration.Fixes #6125
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com