fix: sync structured primary key fields after metadata update#6326
Open
wombatu-kun wants to merge 9 commits intolance-format:mainfrom
Open
fix: sync structured primary key fields after metadata update#6326wombatu-kun wants to merge 9 commits intolance-format:mainfrom
wombatu-kun wants to merge 9 commits intolance-format:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6324
UpdateConfig.fieldMetadataUpdates()correctly persistslance-schema:unenforced-primary-keyandlance-schema:unenforced-primary-key:positionin the field's metadata HashMap, but the corresponding structured fieldunenforced_primary_key_position(used for protobuf serialization andis_unenforced_primary_key()) was never updated. This caused primary key information set via metadata updates to be lost on the next dataset reload.Root cause
apply_update_map()intransaction.rsonly modifiesfield.metadata(a HashMap<String, String>) without syncing the structuredField.unenforced_primary_key_positionfield that drives protobuf serialization and theis_unenforced_primary_key()API.Fix
Field::sync_embedded_metadata()that re-parses well-known metadata keys (lance-schema:unenforced-primary-key,lance-schema:unenforced-primary-key:position) and updates the corresponding structured fields.sync_embedded_metadata()after everyapply_update_map()on field metadata inTransaction::build_manifest().TryFrom<&ArrowField>for Field to reusesync_embedded_metadata()instead of duplicating the parsing logic.