chore: remove custom cast_with_options in favor of upstream#6344
Open
wjones127 wants to merge 4 commits intolance-format:mainfrom
Open
chore: remove custom cast_with_options in favor of upstream#6344wjones127 wants to merge 4 commits intolance-format:mainfrom
wjones127 wants to merge 4 commits intolance-format:mainfrom
Conversation
arrow-cast 57.0.0 added support for FixedSizeList → FixedSizeList casting with the same logic as our custom wrapper, making it redundant. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit ed6e8d3.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
arrow-cast57.0.0 added native support forFixedSizeList → FixedSizeListcasting, which was the only reasonlance_arrow::cast::cast_with_optionsexisted. This removes the wrapper and updates all call sites to usearrow_cast::cast_with_optionsdirectly.