Skip to content

feat: expose granular trace event targets#6853

Open
beinan wants to merge 1 commit into
lance-format:mainfrom
beinan:beinan/expose-event-targets
Open

feat: expose granular trace event targets#6853
beinan wants to merge 1 commit into
lance-format:mainfrom
beinan:beinan/expose-event-targets

Conversation

@beinan
Copy link
Copy Markdown
Contributor

@beinan beinan commented May 20, 2026

Summary

  • Add granular tracing targets for Lance event categories under lance::events::....
  • Preserve the original tracing target in Python log passthrough so LANCE_LOG can filter individual event types directly.
  • Document the new event targets and add Python regression coverage for target-specific log filtering.

Testing

  • PATH=/Users/beinan/.rustup/toolchains/1.94.0-aarch64-apple-darwin/bin:$PATH cargo fmt --all -- --check
  • git diff --check
  • PATH=/Users/beinan/.rustup/toolchains/1.94.0-aarch64-apple-darwin/bin:$PATH cargo check -p lance-core -p lance-io -p lance-index -p lance -p lance-datafusion
  • PATH=/Users/beinan/.rustup/toolchains/1.94.0-aarch64-apple-darwin/bin:$PATH cargo check --manifest-path python/Cargo.toml
  • uv sync --python 3.12 --no-install-project
  • .venv/bin/maturin develop --uv -v
  • uv run --no-sync --python 3.12 pytest -q python/tests/test_log.py::test_lance_log_filters_trace_event_targets python/tests/test_tracing.py::test_tracing_callback
  • uv run --no-sync --python 3.12 ruff format --check python/tests/test_log.py python/tests/test_tracing.py
  • uv run --no-sync --python 3.12 ruff check python/tests/test_log.py python/tests/test_tracing.py

@github-actions github-actions Bot added enhancement New feature or request python labels May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/index.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@beinan beinan marked this pull request as ready for review May 20, 2026 03:27
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant