feat: expose index segments in Python scanner#6872
Open
hfutatzhanghb wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@Xuanwo Hi, could you please help review this PR when have free time? Thanks a lot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose vector index segment selection through the Python scanner API. This adds an
index_segmentsargument toLanceDataset.scanner(...)andScannerBuilder, acceptsstranduuid.UUIDvalues in Python, parses them into RustUuids in the PyO3 binding, and forwards them to the existing RustScanner::with_index_segmentssupport.Why
Rust already supports restricting vector search to selected index segments. Python users creating distributed index segments need the same control from
ds.scanner(...), similar to the existingfragmentsargument.Validation
cargo check --manifest-path python/Cargo.toml -p pylancegit diff --check --cachedI did not complete the targeted pytest run because it triggered a local
pylancerebuild and was stopped to avoid generating additional largetargetartifacts.