fix(java): add diagnostics for imported Arrow streams#6875
Open
beinan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Lance Java diagnostics around Arrow C Data stream readers and a scanner regression for the nested struct case that motivated the lance-spark fix.
Findings
The original
VectorLoaderfailure can be caused by consumers closing or mutating the reader-ownedVectorSchemaRootbetweenloadNextBatch()calls. When the damaged vector is aStructVector, Arrow Java may see schema children still present while the reused vector has zero children, producingshould have as many children as in the schema: found 0 expected N.Changes
LanceArrowReaders, a small wrapper for Arrow readers imported from Lance Arrow C Data streams.Data.importArrayStream(...), includingLanceScanner,AsyncScanner, SQL query output, delta output, and file reads.Testing
This run passed Java checkstyle, Spotless, both targeted Java tests, the JNI build, and the rust-maven-plugin JNI test.