Skip to content

chore: upgrade dify_plugin#745

Open
lcedaw wants to merge 1 commit into
langgenius:mainfrom
lcedaw:main
Open

chore: upgrade dify_plugin#745
lcedaw wants to merge 1 commit into
langgenius:mainfrom
lcedaw:main

Conversation

@lcedaw
Copy link
Copy Markdown

@lcedaw lcedaw commented May 22, 2026

Description

Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format Fixes #123 or Closes #123.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Other

Essential Checklist

Testing

  • I have tested the changes locally and confirmed they work as expected
  • I have added unit tests where necessary and they pass successfully

Bug Fix (if applicable)

  • I have used GitHub syntax to close the related issue (e.g., Fixes #123 or Closes #123)

Additional Information

Please provide any additional context that would help reviewers understand the changes.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels May 22, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the dify_plugin version range in the Python plugin template. Feedback suggests using the canonical package name dify-plugin and increasing the minimum version requirement to 0.7.0 for better consistency and reliability.

@@ -1 +1 @@
dify_plugin>=0.4.0,<0.7.0
dify_plugin>=0.4.0,<0.9.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For a template used to initialize new plugins, it is recommended to use the canonical package name and a more recent version range for better consistency and reliability.

  1. Naming Consistency: Use dify-plugin (with a hyphen) instead of dify_plugin. While PyPI treats them as equivalent, dify-plugin is the canonical name used elsewhere in this repository (e.g., in the test data) and follows standard Python packaging conventions.
  2. Version Pinning: Consider bumping the lower bound to a more recent stable version (e.g., 0.7.0). Allowing versions as old as 0.4.0 in a new template can lead to compatibility issues if the developer's code relies on features introduced in more recent versions of the SDK. New plugins should generally start with a recent, tested version of their dependencies.
dify-plugin>=0.7.0,<0.9.0

@lcedaw lcedaw changed the title update dify_plugin chore: upgrade dify_plugin May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant