chore: upgrade dify_plugin#745
Open
lcedaw wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dify_plugin version range in the Python plugin template. Feedback suggests using the canonical package name dify-plugin and increasing the minimum version requirement to 0.7.0 for better consistency and reliability.
| @@ -1 +1 @@ | |||
| dify_plugin>=0.4.0,<0.7.0 | |||
| dify_plugin>=0.4.0,<0.9.0 | |||
Contributor
There was a problem hiding this comment.
For a template used to initialize new plugins, it is recommended to use the canonical package name and a more recent version range for better consistency and reliability.
- Naming Consistency: Use
dify-plugin(with a hyphen) instead ofdify_plugin. While PyPI treats them as equivalent,dify-pluginis the canonical name used elsewhere in this repository (e.g., in the test data) and follows standard Python packaging conventions. - Version Pinning: Consider bumping the lower bound to a more recent stable version (e.g.,
0.7.0). Allowing versions as old as0.4.0in a new template can lead to compatibility issues if the developer's code relies on features introduced in more recent versions of the SDK. New plugins should generally start with a recent, tested version of their dependencies.
dify-plugin>=0.7.0,<0.9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Please also include the issue number if this is related to an issue using the format
Fixes #123orCloses #123.Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Please provide any additional context that would help reviewers understand the changes.