feat: auto-detect pip mirror#750
Draft
BeautyyuYanli wants to merge 3 commits into
Draft
Conversation
wylswz
reviewed
May 30, 2026
| ) | ||
|
|
||
| const ( | ||
| alibabaCloudPypiMirrorURL = "https://mirrors.aliyun.com/pypi/simple/" |
Contributor
There was a problem hiding this comment.
I would suggest moving mirror candidate to a environment variable instead of a const.
Having multiple default candidates may help improve the reliability.
Contributor
Author
There was a problem hiding this comment.
Those who want to set ENV may set the mirror directly? This AUTO DETECT is meant to provide a default and out-of-box value.
Contributor
There was a problem hiding this comment.
I'm rethinking about the design. I'll try
- Not to introduce another dependency on CF. Instead, rely on the connectivity to the configured mirror.
- Make the connectivity issue visible to the user. If the mirrors are unavailable to the service (auto detected or explicitly configured, users should be able to see that installing plugins)
Approach 1
- Add a background checker, and expose the connectivity to healthiness probe of this service.
- Add on indicator to Dify console.
Approach 2
Do a connectivity check when starting up, fail fast with a clear log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds startup-time automatic PyPI mirror selection for plugin dependency installation.
Environment variables
PIP_MIRROR_AUTO_DETECTtruePIP_MIRROR_URLDetection behavior
https://cloudflare.com/cdn-cgi/traceat startup to detect the public IP region.config.PipMirrorUrlis populated before plugin runtimes install Python dependencies.Documentation and tests
.env.exampleandREADME.mdto describe the mirror-related configuration behavior.Type of Change
Essential Checklist
Testing
Bug Fix (if applicable)
Fixes #123orCloses #123)Additional Information
Local verification performed:
go build -o /tmp/opencode/dify-plugin-daemon-server cmd/server/main.go go test ./cmd/server ./internal/types/appThis PR is drafted by
gpt-5.4andgpt-5.5. I'm responsible for all the changes. I have reviewed the code and varified the behavior, while breaks may still exist. Reach me to fix in this case.