Skip to content

Add a SpinerEosDependsRhoSie constructor that uses an existing eos object to generate a spiner eos#632

Merged
buechlerm merged 36 commits into
mainfrom
buechler/spiner_constructor
Jun 9, 2026
Merged

Add a SpinerEosDependsRhoSie constructor that uses an existing eos object to generate a spiner eos#632
buechlerm merged 36 commits into
mainfrom
buechler/spiner_constructor

Conversation

@buechlerm

@buechlerm buechlerm commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

Much of this was generated by AI. I had asked it to emulate sesame2spiner in terms of parameters for grid generation. Seems somewhat heavyweight, but there are defaults. Ultimately, if somebody proposes a different way of parameterizing the grids, I'd accept that.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@buechlerm buechlerm self-assigned this Apr 9, 2026
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp
@buechlerm buechlerm force-pushed the buechler/spiner_constructor branch 2 times, most recently from 522f37e to cc4ee8f Compare April 13, 2026 14:13
@buechlerm buechlerm force-pushed the buechler/spiner_constructor branch from cc4ee8f to d471df4 Compare May 4, 2026 16:19
@buechlerm

Copy link
Copy Markdown
Collaborator Author

Ok, this is effectively feature complete. I've made choices on what is the prefered path from an incomplete eos to the tables, but I'm not dead set on them, so if somebody has a very strong preference, I can change it. @adamdempsey90 was also working on some sesame2spiner changes and if he wants a different way of defining the table grids, I'm open to that as well. Finally, I said feature complete, but a future feature that is probably required is writing an sp5 file (for restarts at minimum). I'm putting that off till later.

@buechlerm

Copy link
Copy Markdown
Collaborator Author

There are actually a few more features we would want (I just don't need them for my Ristra work). Here, I punted on split-eos and mass fractions. We definitely want to optionally support those as well. Again, punting on those, till later, unless somebody sees something atrocious about this MR that'll make adding those features difficult, later.

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @buechlerm this is really nice and it's functionality we've been missing for a long time. I have some review comments that entail varying amounts of work. Feel free to push back on them.

Comment thread doc/sphinx/src/examples.rst
Comment thread plan_histories/MR632-2026-05-04-add-spiner-constructor-from-eos.md Outdated
Comment thread plan_histories/MR632-2026-05-04-add-spiner-constructor-from-eos.md Outdated
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp Outdated
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp Outdated
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp Outdated
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp Outdated
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp
Comment thread test/test_eos_spiner_constructors.cpp
@buechlerm buechlerm force-pushed the buechler/spiner_constructor branch from 8ea20e7 to b627b93 Compare May 29, 2026 17:14
@buechlerm

Copy link
Copy Markdown
Collaborator Author

Took me some time, sorry, but I believe I've addressed comments.

Comment thread singularity-eos/base/eos_concepts.hpp
Comment thread singularity-eos/base/eos_concepts.hpp Outdated
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp Outdated

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great now. Thanks for the lift! A few nitpicks still, but I think they're non-blocking.

Comment thread sesame2spiner/generate_files.cpp
Comment thread sesame2spiner/generate_files.cpp
Comment thread sesame2spiner/generate_files.cpp
Comment thread doc/sphinx/src/examples.rst
Comment thread doc/sphinx/src/models.rst
Comment thread singularity-eos/base/eos_concepts.hpp Outdated
Comment thread singularity-eos/base/finite_diff.hpp
Comment thread singularity-eos/eos/eos_spiner_construction.hpp
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp
Comment thread singularity-eos/eos/eos_spiner_rho_sie.hpp
@Yurlungur

Copy link
Copy Markdown
Collaborator

@buechlerm is this ready to go? re-git indicates yes? if so, merge when ready

@buechlerm buechlerm merged commit 271afd6 into main Jun 9, 2026
9 checks passed
@buechlerm buechlerm deleted the buechler/spiner_constructor branch June 9, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants