Add a SpinerEosDependsRhoSie constructor that uses an existing eos object to generate a spiner eos#632
Conversation
522f37e to
cc4ee8f
Compare
cc4ee8f to
d471df4
Compare
|
Ok, this is effectively feature complete. I've made choices on what is the prefered path from an incomplete eos to the tables, but I'm not dead set on them, so if somebody has a very strong preference, I can change it. @adamdempsey90 was also working on some sesame2spiner changes and if he wants a different way of defining the table grids, I'm open to that as well. Finally, I said feature complete, but a future feature that is probably required is writing an sp5 file (for restarts at minimum). I'm putting that off till later. |
|
There are actually a few more features we would want (I just don't need them for my Ristra work). Here, I punted on split-eos and mass fractions. We definitely want to optionally support those as well. Again, punting on those, till later, unless somebody sees something atrocious about this MR that'll make adding those features difficult, later. |
Yurlungur
left a comment
There was a problem hiding this comment.
Thanks, @buechlerm this is really nice and it's functionality we've been missing for a long time. I have some review comments that entail varying amounts of work. Feel free to push back on them.
…nd an object representing grid parameters
8ea20e7 to
b627b93
Compare
Still need to incorporate bounds checking
Moves a bunch of the shared code into eos/eos_spiner_construction.hpp
|
Took me some time, sorry, but I believe I've addressed comments. |
Make sesame2spiner use spinerTableGridParams
Yurlungur
left a comment
There was a problem hiding this comment.
This looks great now. Thanks for the lift! A few nitpicks still, but I think they're non-blocking.
|
@buechlerm is this ready to go? re-git indicates yes? if so, merge when ready |
PR Summary
Much of this was generated by AI. I had asked it to emulate sesame2spiner in terms of parameters for grid generation. Seems somewhat heavyweight, but there are defaults. Ultimately, if somebody proposes a different way of parameterizing the grids, I'd accept that.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: