fix: set connection401Error before invoking resultCallback in onError

launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/sdk/android/StreamingDataSource.java

@@ -133,11 +133,11 @@ public void onError(Throwable t) {
                         if (code >= 400 && code < 500) {
                             logger.error("Encountered non-retriable error: {}. Aborting connection to stream. Verify correct Mobile Key and Stream URI", code);
                             running = false;
-                            resultCallback.onError(new LDInvalidResponseCodeFailure("Unexpected Response Code From Stream Connection", t, code, false));
                             if (code == 401) {
                                 connection401Error = true;
                                 dataSourceUpdateSink.shutDown();
                             }
+                            resultCallback.onError(new LDInvalidResponseCodeFailure("Unexpected Response Code From Stream Connection", t, code, false));
                             stop(null);
                         } else {
                             eventSourceStarted = System.currentTimeMillis();

launchdarkly-android-client-sdk/src/test/java/com/launchdarkly/sdk/android/StreamingDataSourceTest.java

@@ -617,13 +617,6 @@ public void startWithHttp401ShutsDownSink() throws Exception {
             LDInvalidResponseCodeFailure failure = (LDInvalidResponseCodeFailure) error;
             assertEquals(401, failure.getResponseCode());
             assertFalse(failure.isRetryable());
-            // The background thread calls resultCallback.onError() before
-            // dataSourceUpdateSink.shutDown(), so shutDownCalled may not be true yet.
-            // Poll briefly to allow the background thread to complete.
-            long deadline = System.currentTimeMillis() + 1000;
-            while (!dataSourceUpdateSink.shutDownCalled && System.currentTimeMillis() < deadline) {
-                Thread.sleep(10);
-            }
             assertTrue(dataSourceUpdateSink.shutDownCalled);
         }
     }