Skip to content

chore: migrating current react features#1235

Open
joker23 wants to merge 1 commit intomainfrom
skz/sdk-2106/react-sdk-meta-current
Open

chore: migrating current react features#1235
joker23 wants to merge 1 commit intomainfrom
skz/sdk-2106/react-sdk-meta-current

Conversation

@joker23
Copy link
Copy Markdown
Contributor

@joker23 joker23 commented Mar 30, 2026

This PR copies the react features that are in https://github.com/launchdarkly/react-client-sdk/blob/main/.sdk_metadata.json to the new js-core react sdk met.

NOTE: there will be another PR to add in features that are supported in the new sdk (if any)


Note

Low Risk
Low risk metadata-only change, but incorrect feature/version mappings could mislead tooling or documentation that consumes this file.

Overview
Updates .sdk_metadata.json to replace the React SDK’s single contexts feature entry with a full, versioned feature matrix (for example allFlags, bootstrapping, secureMode, hooks, and others), aligning React metadata with the upstream React client SDK feature list.

Written by Cursor Bugbot for commit 1684feb. This will update automatically on new commits. Configure here.


Open with Devin

@joker23 joker23 requested a review from a team as a code owner March 30, 2026 19:32
cursor[bot]

This comment was marked as resolved.

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179253 bytes
Compressed size limit: 200000
Uncompressed size: 828804 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 37015 bytes
Compressed size limit: 38000
Uncompressed size: 202741 bytes

@github-actions
Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31446 bytes
Compressed size limit: 34000
Uncompressed size: 111621 bytes

devin-ai-integration[bot]

This comment was marked as resolved.

@joker23 joker23 force-pushed the skz/sdk-2106/react-sdk-meta-current branch from af8e904 to 1684feb Compare March 30, 2026 21:05
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

"relayProxyProxy": { "introduced": "2.9" },
"secureMode": { "introduced": "2.18" },
"track": { "introduced": "2.9" },
"variationDetail": { "introduced": "2.21" }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature versions reference wrong SDK's version history

Medium Severity

The introduced version numbers (e.g., "2.9", "3.0", "3.8") are from the old launchdarkly-react-client-sdk package, but this metadata entry is for the new @launchdarkly/react-sdk which has only had versions 0.0.1, 0.1.0, and 0.1.1. Every other SDK in this file has introduced versions within its own actual version range. The previous value "contexts": { "introduced": "0.0.1" } was correct for this package. Any tooling using these version numbers to determine feature availability would conclude that the current SDK supports zero features, since all introduced versions exceed 0.1.1.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants