Fix SSL deprecation, test assertion, and missing mypy dep#56
Open
davidrecordon wants to merge 1 commit intolawtancool:masterfrom
Open
Fix SSL deprecation, test assertion, and missing mypy dep#56davidrecordon wants to merge 1 commit intolawtancool:masterfrom
davidrecordon wants to merge 1 commit intolawtancool:masterfrom
Conversation
…ypy dev dep - Replace deprecated aiohttp TCPConnector(verify_ssl=False) with ssl=False in director.py and websocket.py to silence DeprecationWarnings - Fix test_sio_connect_with_session to assert ssl_verify=True, matching the production code changed in ee45410 - Add mypy to requirements-dev.txt (was stated as added but missing) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
@davidrecordon let me know when you're done testing the HA PR stuff so I can merge the fixes all at once and cut a new release |
Contributor
Author
|
@lawtancool tested 2.0.2 and it's good to go! This PR came out of a quick review of the past few commits, nothing major. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiohttp.TCPConnector(verify_ssl=False)withssl=Falseindirector.pyandwebsocket.pyto eliminateDeprecationWarningon aiohttp 3.x (removed in 4.0)test_sio_connect_with_sessionto assertssl_verify=True, matching the production code from ee45410mypytorequirements-dev.txt— was stated as added in 25568bf but was missing from the fileTest plan
DeprecationWarningfrom aiohttp in logs during normal operation🤖 Generated with Claude Code