Skip to content

remove: bg color of MuiDrawer #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KhushamBansal wants to merge 6 commits into from
Closed

remove: bg color of MuiDrawer #1366

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1802846
remove: bg color of MuiDrawer
KhushamBansal Mar 5, 2026
e701cd2
Merge branch 'master' into fix/MuiDrawer
KhushamBansal Mar 16, 2026
dae956a
Merge branch 'master' into fix/MuiDrawer
Rajesh-Nagarajan-11 Mar 16, 2026
ea7f269
Merge branch 'master' into fix/MuiDrawer
Rajesh-Nagarajan-11 Mar 31, 2026
569fd5d
Merge branch 'master' into fix/MuiDrawer
Rajesh-Nagarajan-11 Mar 31, 2026
497aea8
Merge branch 'master' into fix/MuiDrawer
Rajesh-Nagarajan-11 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/theme/components/drawer.modifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
import { Components, Theme } from '@mui/material';
import { DARK_BLUE_GRAY } from '../colors';
Copy link
Copy Markdown
Member

@leecalcote leecalcote Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KhushamBansal, what aspects of the upstream projects have you assessed for impact?

What changes need to be made in consumers of this component in order to prevent being adversely affected?

Copy link
Copy Markdown
Member Author

@KhushamBansal KhushamBansal Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leecalcote
I spent a significant amount of time trying to set up Meshery locally to properly test this PR, but I ran into hardware limitations on my system. Therefore, I also asked maintainers if they could test (comment).

Initially, I tried setting it up on my Windows machine, but that didn’t work out. I then switched to a Linux setup using an external HDD and it worked partially. VS Code consistently crashes whenever I make changes in the repo, which prevents me from running or testing anything reliably.

Because of this, I’m unable to validate the changes in this PR. I am closing this PR so that someone else could work on this.


export const MuiDrawer: Components<Theme>['MuiDrawer'] = {
styleOverrides: {
root: {
'& .MuiDrawer-paper': {
boxSize: 'border-box',
background: DARK_BLUE_GRAY
boxSize: 'border-box'
}
}
}
Expand Down
Loading