Make compatible with ansible 2.10.3 in windows target/adoptopenjdk-fallback combination#119
Open
rockdreamer wants to merge 2 commits intolean-delivery:masterfrom
Open
Make compatible with ansible 2.10.3 in windows target/adoptopenjdk-fallback combination#119rockdreamer wants to merge 2 commits intolean-delivery:masterfrom
rockdreamer wants to merge 2 commits intolean-delivery:masterfrom
Conversation
Contributor
Author
|
Hi, any chance of getting these merged? Thanks :) |
These changes were required for me to download openjdk 11 from the adoptopenjdk. Target machine was running windows 2019. Machine where ansible is running is macos 11, ansible 2.10.3
According to recent win_tempfile documentation, its result is a dictionary, with the temporary path under the path key. https://docs.ansible.com/ansible/latest/collections/ansible/windows/win_tempfile_module.html Updating uses of the result to make use of the .path value This makes is possible for me to use the role on macos 11, provisioning a win2019 VM, using ansible 2.10.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to accomodate change in the returned api page and to better deal with the result of win_tempfile.
This makes is possible for me to use the role on macos 11, provisioning a win2019 VM, using ansible 2.10.3