Skip to content

fix(windows): create missing registry keys in enable #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jabagawee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(windows): create missing registry keys in enable #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions lib/src/app_auto_launcher_impl_windows.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,21 @@ class AppAutoLauncherImplWindows extends AppAutoLauncher {

late String _registryValue;

static const String _runRegistryPath =
r'Software\Microsoft\Windows\CurrentVersion\Run';

static const String _startupApprovedRegistryPath =
r'Software\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run';

RegistryKey get _regKey => Registry.openPath(
RegistryHive.currentUser,
path: r'Software\Microsoft\Windows\CurrentVersion\Run',
path: _runRegistryPath,
desiredAccessRights: AccessRights.allAccess,
);

RegistryKey get _startupApprovedRegKey => Registry.openPath(
RegistryHive.currentUser,
path:
r'Software\Microsoft\Windows\CurrentVersion\Explorer\StartupApproved\Run',
path: _startupApprovedRegistryPath,
desiredAccessRights: AccessRights.allAccess,
);

Expand All @@ -47,7 +52,13 @@ class AppAutoLauncherImplWindows extends AppAutoLauncher {

@override
Future<bool> enable() async {
_regKey.createValue(
// openPath (used on the read path) throws when a key does not exist, and
// createValue only writes to an already-open handle. On a fresh install
// the Run and StartupApproved\Run keys may not exist yet, so create them
// first. createKey creates any missing keys along the path and opens an
// existing key unchanged.
final regKey = Registry.currentUser.createKey(_runRegistryPath);
regKey.createValue(
RegistryValue.string(
appName,
_registryValue,
Expand All @@ -58,7 +69,10 @@ class AppAutoLauncherImplWindows extends AppAutoLauncher {
// "2" as a first byte in this register means that the autostart is enabled
bytes[0] = 2;

_startupApprovedRegKey.createValue(RegistryValue.binary(appName, bytes));
final startupApprovedRegKey = Registry.currentUser.createKey(
_startupApprovedRegistryPath,
);
startupApprovedRegKey.createValue(RegistryValue.binary(appName, bytes));

return true;
}
Expand Down