Skip to content

feat(temperature): PositiveTemperature refactor#976

Open
ichxorya wants to merge 1 commit intoleanprover-community:masterfrom
SEhumantics:0503-positivetemperature
Open

feat(temperature): PositiveTemperature refactor#976
ichxorya wants to merge 1 commit intoleanprover-community:masterfrom
SEhumantics:0503-positivetemperature

Conversation

@ichxorya
Copy link
Contributor

@ichxorya ichxorya commented Mar 5, 2026

At this first commit, I would follow the suggestion of @jstoobysmith to break the PR down into pieces. Hopefully this could be reviewed as a passing commit 😄

However, note that at this point, the Basic.lean file only contain:

  • Temperature and PositiveTemperature definitions: type conversions, ext lemma, linear order and relevant order/comparison lemmas.
  • Beta and Inverse Beta (ofBeta) was moved from Temperature to PositiveTemperature, with additional lemmas in their antimonotonicity (T1 > T2 <=> Beta T1 < Beta T2, ect.)

For the rest (derivatives, limits, ect.), I have also proved them following the PositiveTemperature refactor here (https://github.com/SEhumantics/PhysLean/tree/feat/nghiabt/postemp/PhysLean/Thermodynamics/Temperature). However, I can only commit more until further acceptance from maintainer revisions!


Referred issues: #861 #860 - #892 (directly dependent on the Beta and Inverse Beta functions)

@ichxorya ichxorya marked this pull request as ready for review March 6, 2026 03:31
@ichxorya ichxorya marked this pull request as draft March 6, 2026 03:31
@jstoobysmith
Copy link
Member

Hey, when you are ready for this to be reviewed, could you unmark it as a draft?

@ichxorya
Copy link
Contributor Author

ichxorya commented Mar 6, 2026

Hey, when you are ready for this to be reviewed, could you unmark it as a draft?

Yes I think it is ready, but I marked as draft since it's not ready to be merge. Can you please review this section first? I'd like to add the rest of the original Basic.lean but it would be too lengthy for now.

@ichxorya ichxorya marked this pull request as ready for review March 7, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants