Add int-type Authz ID proto fields alongside any string-type proto fields#8754
Open
ezekiel wants to merge 15 commits into
Open
Add int-type Authz ID proto fields alongside any string-type proto fields#8754ezekiel wants to merge 15 commits into
ezekiel wants to merge 15 commits into
Conversation
This is stage one of normalizing Authz ID to be consistently int64-type.
ezekiel
commented
May 20, 2026
aarongable
requested changes
May 20, 2026
Fixes to Load Generator incoming.
aarongable
reviewed
May 29, 2026
Co-authored-by: Aaron Gable <aaron@letsencrypt.org>
AuthorizationID and AuthorizationIDs in sa.proto where unreferenced and unused. Apparent remnants from before Authz 2.
Member
Author
|
Still adding real fixes for load-generator. |
this instead of overloading a core.Authorization.ID
aarongable
requested changes
Jun 3, 2026
jsha
approved these changes
Jun 10, 2026
jsha
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Two comments:
You asked this morning about possible split points for future PRs like this. One natural split point I noticed: the load-generator changes. That could be a nice tidy separate PR refactoring the load-generator not to depend on core.Authorization. Not needed for this one but as an FYI.
Also, I noticed the if id != 0 { ... } else if idstr != "" { ... } else { ... } pattern in four places. That's enough to justify a shared helper:
// integerID returns `id` if it is non-zero, otherwise `idStr` parsed as an integer.
// Returns either if both args have their zero value.
func integerID(id int64, idStr string) (int64, error) {
Member
Author
|
Very helpful, thank you. |
aarongable
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is stage one of normalizing Authz ID to be consistently int64-type (#8722).