Add support for macOS (macFUSE 4.10.0) #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks like the failed check is not a result of my changes:
|
Collaborator
|
@bfleischer just bumped the version in master |
Collaborator
|
@bfleischer please bump up the version of v3 to v4 on your branch as well so that the check passes |
The fuse_opt compatibility code is no longer needed on macOS. Remove it since it is not included on any other platform.
The header file is no longer available in macFUSE 4.
macFUSE will create the mounpoint (in case it does not exist) before mounting the volume. This allows unprivileged users to mount volumes under /Volumes.
Some macOS specific features require FUSE API modifications and extensions that break compatibility with the vanilla FUSE API. Setting the compile-time flag FUSE_DARWIN_ENABLE_EXTENSIONS to 0, when building a file system, disables those API extensions. By default, the macOS specific API modifications and extensions are enabled.
bfleischer
force-pushed
the
feature/macfuse-support
branch
from
fcca4f0 to
ccb6821
Compare
Collaborator
Author
|
Bumping to v4 seems to have done the trick. I rebased my commits on your bump commit. |
Collaborator
Author
|
@h4sh5 Do you have any objections to merging the pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macFUSE 4.10.0 is the first macFUSE release that ships libfuse 3. The patches in this pull request add support for macFUSE 4.10.0 and should not have any effect on other supported platforms.