fix: ControlIHave and ControlIWant message types to bytes from string#1146
Open
barnabasbusa wants to merge 4 commits intolibp2p:mainfrom
Open
fix: ControlIHave and ControlIWant message types to bytes from string#1146barnabasbusa wants to merge 4 commits intolibp2p:mainfrom
barnabasbusa wants to merge 4 commits intolibp2p:mainfrom
Conversation
Changed types of topicID and messageIDs from string to bytes in ControlIHave and ControlIWant messages. This change is required due to this error message I saw: ``` iwant_msg.messageIDs.extend(msg_ids) UnicodeDecodeError: 'utf-8' codec can't decode byte 0x95 ``` This happened because msg_ids contained raw binary hashes (arbitrary bytes), and when extending a repeated string field, Python's protobuf tries to decode them as UTF-8.
Author
|
@acul71 mind taking a quick look? Shouldn't affect much, but would really help for me to be able to use latest upstream again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed types of topicID and messageIDs from string to bytes in ControlIHave and ControlIWant messages.
This change is required due to this error message I saw:
This happened because msg_ids contained raw binary hashes (arbitrary bytes), and when extending a repeated string field, Python's protobuf tries to decode them as UTF-8.
What was wrong?
Issue #
How was it fixed?
Summary of approach.
To-Do
Cute Animal Picture