Open
Conversation
marten-seemann
force-pushed
the
panic-handler
branch
from
f4ed9bc to
8b33173
Compare
Stebalien
approved these changes
Apr 23, 2022
Member
Stebalien
left a comment
Stebalien
left a comment
There was a problem hiding this comment.
LGTM, but we could get "stuck" waiting on a goroutine that has died. We probably need some way to cancel the context if any of these functions exit.
|
2022-09-16 conversation: there are some additional code changes to do here. Given P3, don't expect to get to it in the short term. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22. Unfortunately, there are quite a few places we need to protect here, but there's a lot of DNS message parsing and serialization happening here.
Part of libp2p/go-libp2p#1389.