Clean up compiler warnings except fallthrough#46
Open
yum-food wants to merge 1 commit into
Open
Conversation
YongRui0402
added a commit
to YongRui0402/minimp4
that referenced
this pull request
Mar 28, 2026
Reviewed all 35 issues and 14 PRs from lieff/minimp4: - 9 accepted for fixing (security bugs, memory safety, compatibility) - 11 already included/fixed in our fork - 6 deferred for evaluation - 3 rejected (out of scope) - 16 skipped (questions, resolved, not actionable) Priority fixes identified: heap overflow (lieff#50), memory access (lieff#42), crash on malformed input (lieff#33), wrong handler_type (lieff#41), audio samplerate (lieff#48), compiler warnings (lieff#31/lieff#46). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
YongRui0402
added a commit
to YongRui0402/minimp4
that referenced
this pull request
Mar 28, 2026
Cherry-picked from lieff#46: - Remove dead next_dsi() function (unused code) - Fix signed/unsigned comparison warnings with (int) casts - Remove unused enum variable name 'e' - Fix payload_bytes > file_size comparison type mismatch All 23 tests pass with ASan/UBSan. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
YongRui0402
added a commit
to YongRui0402/minimp4
that referenced
this pull request
Mar 28, 2026
Steps completed: - Added upstream remote (0 new upstream commits) - Cataloged 35 issues + 14 PRs in docs/upstream-review.md - Applied PR lieff#46 (compiler warnings cleanup) Step 5 (commenting on upstream issues) requires user approval. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self explanatory. Just cleaning up a few compiler warnings that I hit in my personal project.