-
Notifications
You must be signed in to change notification settings - Fork 449
Upstream VssStoreBuilder and VssStore to lightning-persister
#4323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2f2b6bd
2827b96
34db635
7414d20
d861d3d
f9a9a81
ad76745
ba5aea6
6667ac1
67b24f9
9bafd93
43a38c9
9686cb9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: VSS Tests | ||
|
|
||
| on: [push, pull_request] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build-and-test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| services: | ||
| postgres: | ||
| image: postgres:latest | ||
| ports: | ||
| - 5432:5432 | ||
| env: | ||
| POSTGRES_DB: postgres | ||
| POSTGRES_USER: postgres | ||
| POSTGRES_PASSWORD: postgres | ||
| options: >- | ||
| --health-cmd pg_isready | ||
| --health-interval 10s | ||
| --health-timeout 5s | ||
| --health-retries 5 | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| path: rust-lightning | ||
| - name: Checkout VSS | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: lightningdevkit/vss-server | ||
| path: vss-server | ||
|
|
||
| - name: Build and Deploy VSS Server | ||
| run: | | ||
| cd vss-server/rust | ||
| cargo run server/vss-server-config.toml > /tmp/vss-server.log 2>&1 & | ||
| until curl -sf http://localhost:8080/vss > /dev/null; do sleep 1; done | ||
| - name: Run VSS tests | ||
| run: | | ||
| cd rust-lightning/lightning-persister | ||
| export TEST_VSS_BASE_URL="http://localhost:8080/vss" | ||
| RUSTFLAGS="--cfg vss_test" cargo test --features vss vss_store | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,4 +67,5 @@ check-cfg = [ | |
| "cfg(simple_close)", | ||
| "cfg(peer_storage)", | ||
| "cfg(tor)", | ||
| "cfg(vss_test)", | ||
| ] | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,11 +17,15 @@ rustdoc-args = ["--cfg", "docsrs"] | |||||
|
|
||||||
| [features] | ||||||
| tokio = ["dep:tokio"] | ||||||
| vss = ["dep:vss-client", "dep:tokio", "dep:getrandom", "dep:lightning-macros"] | ||||||
tnull marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
|
||||||
| [dependencies] | ||||||
| bitcoin = "0.32.2" | ||||||
| lightning = { version = "0.3.0", path = "../lightning" } | ||||||
| lightning-macros = { version = "0.2.0", path = "../lightning-macros", optional = true } | ||||||
| tokio = { version = "1.35", optional = true, default-features = false, features = ["rt-multi-thread"] } | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The code uses This likely compiles today only because
Suggested change
|
||||||
| vss-client = { package = "vss-client-ng", version = "0.5", optional = true } | ||||||
| getrandom = { version = "0.3", optional = true } | ||||||
|
|
||||||
| [target.'cfg(windows)'.dependencies] | ||||||
| windows-sys = { version = "0.48.0", default-features = false, features = ["Win32_Storage_FileSystem", "Win32_Foundation"] } | ||||||
|
|
@@ -32,6 +36,7 @@ criterion = { version = "0.4", optional = true, default-features = false } | |||||
| [dev-dependencies] | ||||||
| lightning = { version = "0.3.0", path = "../lightning", features = ["_test_utils"] } | ||||||
| bitcoin = { version = "0.32.2", default-features = false } | ||||||
| rand = { version = "0.9.2", default-features = false, features = ["thread_rng"] } | ||||||
| tokio = { version = "1.35", default-features = false, features = ["macros"] } | ||||||
|
|
||||||
| [lints] | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.