feat: add VPC interface networking and firewall controls#220
Open
lots0logs wants to merge 1 commit intolinode:mainfrom
Open
feat: add VPC interface networking and firewall controls#220lots0logs wants to merge 1 commit intolinode:mainfrom
lots0logs wants to merge 1 commit intolinode:mainfrom
Conversation
lots0logs
requested review from
Copilot,
dawiddzhafarov,
ezilber-akamai and
psnoch-akamai
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Adds opt-in support for Linode’s newer interface/VPC networking mode in the Linode docker-machine driver, including validation and interface-level firewall attachment options, to address feature request #219.
Changes:
- Introduces
--linode-use-interfaces+ VPC subnet/private IP options and validates compatibility with legacy private IP behavior. - Adds support for attaching firewall IDs to the public and VPC interfaces when using interface/VPC mode.
- Updates README documentation and expands unit tests for the new flags/validation and VPC IP selection helper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Documents the new networking modes and new CLI/env options, including examples. |
| pkg/drivers/linode/linode.go | Implements interface/VPC instance creation path, flag validation, firewall attachment, and updated IP discovery logic. |
| pkg/drivers/linode/linode_test.go | Adds coverage for new flag validation behaviors and VPC IP selection helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--linode-public-interface-firewall-id--linode-vpc-interface-firewall-idFixes #219