Skip to content

TPT-4368: Update integration tests due to deprecated "vpcs" for NB create #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mawilk90 wants to merge 2 commits into
base: proj/nb-front-end-ip-in-vpc
Choose a base branch
from
+29 −2
Open

TPT-4368: Update integration tests due to deprecated "vpcs" for NB create #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b00142a
Replace vpcs with backend_vpcs to be passed to POST /nodebalancers
mawilk90 Mar 31, 2026
7d96c3d
Add test for deprecated VPCs attribute
mawilk90 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 29 additions & 2 deletions test/integration/models/nodebalancer/test_nodebalancer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def test_nb_with_backend_only(test_linode_client, create_vpc_with_subnet):
nb = client.nodebalancer_create(
region=create_vpc_with_subnet[0].region,
label=label,
vpcs=[
backend_vpcs=[
{
"vpc_id": create_vpc_with_subnet[0].id,
"subnet_id": create_vpc_with_subnet[1].id,
Expand Down Expand Up @@ -471,7 +471,7 @@ def test_nb_with_frontend_and_backend_in_different_vpcs(
nb = client.nodebalancer_create(
region=region,
label=label,
vpcs=[{"vpc_id": vpc_backend, "subnet_id": subnet_backend}],
backend_vpcs=[{"vpc_id": vpc_backend, "subnet_id": subnet_backend}],
frontend_vpcs=[
{
"subnet_id": subnet_frontend.id,
Expand Down Expand Up @@ -508,3 +508,30 @@ def test_nb_with_frontend_and_backend_in_different_vpcs(

nb.delete()
vpc_frontend.delete()


def test_nb_with_deprecated_vpcs_attribute(
test_linode_client, create_vpc_with_subnet
):
# TODO: The test will be deleted when a deprecated vpcs attribute can no longer be used
client = test_linode_client
label = get_test_label(8)

nb = client.nodebalancer_create(
region=create_vpc_with_subnet[0].region,
label=label,
vpcs=[
{
"subnet_id": create_vpc_with_subnet[1].id,
}
],
)

assert isinstance(
ipaddress.ip_address(nb.ipv4.address), ipaddress.IPv4Address
)
assert isinstance(ipaddress.ip_address(nb.ipv6), ipaddress.IPv6Address)
assert nb.frontend_address_type == "public"
assert nb.frontend_vpc_subnet_id is None

nb.delete()
Loading