-
Notifications
You must be signed in to change notification settings - Fork 396
upcoming: [UIE-9461] IAM Parent/Child - server side filter on Switch Account Drawer #13318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
upcoming: [UIE-9461] IAM Parent/Child - server side filter on Switch Account Drawer #13318
Conversation
5af6080 to
97b69c1
Compare
| ? errors.allChildAccountsError | ||
| : errors.childAccountInfiniteError; | ||
|
|
||
| if (hasError) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this to the SwitchAccountDrawer component since it’s needed for both the List and Table.
…tch Account drawer
2c575e6 to
d1e9d05
Compare
d1e9d05 to
aa9e511
Compare
| onPageSizeChange={( | ||
| e: CustomEvent<{ page: number; pageSize: number }> | ||
| ) => handlePageSizeChange(Number(e.detail.pageSize))} | ||
| page={page} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bnussman-akamai , I have a question about pagination from usePaginationV2:
we use a table inside the drawer, and with usePaginationV2 we need to provide a currentRoute. That’s not straightforward in this case because it’s a user menu. I tried using location and useMatch, but it didn’t help. Is there a way to use it here?
I’d appreciate any suggestions!
Cloud Manager UI test results🎉 866 passing tests on test run #10 ↗︎
|
Description 📝
This PR added server side filtering for Switch Account drawer
Changes 🔄
List any change(s) relevant to the reviewer.
akamai-cds-react-components.Scope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅