Skip to content

Conversation

@venkymano-akamai
Copy link
Contributor

@venkymano-akamai venkymano-akamai commented Feb 4, 2026

Description 📝

Ability to restrict the maximum selectable values in the CloudPulse metrics and alerts dimension filters.

Changes 🔄

  1. New feature flag maxDimensionFiltersValues for controlling the maximum selectable dimension filter value
  2. Disable select all and deselect all option incase of options greater than max selection limit
  3. Once max items are selected , disable the rest of the options
  4. Display a helper text 'Select up to ${max} values' for dropdown
  5. This applies only for in operator

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️ Next Release date

Preview 📷

Before After
Screenshot 2026-02-04 at 5 09 26 PM Screenshot 2026-02-04 at 5 09 45 PM
Screenshot 2026-02-04 at 5 11 47 PM Screenshot 2026-02-04 at 5 11 37 PM

How to test 🧪

Metrics

  1. Login into cloud manager application and enable legacy mocks
  2. Navigate to monitor and then to metrics
  3. Select the Linode dashboard and the required filters
  4. Scroll down network traffic widget and click on the dimension filter icon
  5. Add a filter Test and select In operator and select more than 5 values.
  6. You would see after the 5th selection, rest of the selections are disabled
  7. You might also see select all is hidden, since at max only 5 values can be selected and the number of options exceeded the limit

Alerts

  1. Login into cloud manager application and enable legacy mocks
  2. Navigate to monitor and then to alerts
  3. Click on Create Alert button
  4. Select the service type linode and scope entity
  5. In the Criteria second, select Date field and select Network Traffic
  6. You might see the dimension filter add button enabled, click and add the dimension Test
  7. Select In operator and select more than 5 values.
  8. You would see after the 5th selection, rest of the selections are disabled
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@venkymano-akamai venkymano-akamai changed the title [DI-29170] - Value field selection limitation in CloudPulse metrics and alerts dimension filters Add: [DI-29170] - Value field selection limitation in CloudPulse metrics and alerts dimension filters Feb 4, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to restrict the maximum number of selectable values in CloudPulse metrics and alerts dimension filters, controlled by a feature flag.

Changes:

  • Added maxDimensionFiltersValues feature flag to control selection limits
  • Implemented UI restrictions that disable options once the limit is reached and hide select/deselect all buttons when appropriate
  • Added validation schema to enforce the maximum selection limit for the 'in' operator

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
featureFlags.ts Added maxDimensionFiltersValues property to AclpAlerting interface
CloudPulseDimensionFilterRenderer.tsx Passed feature flag value to form context for validation
CloudPulseDimensionFilterFields.tsx Replaced setValue with resetField to properly reset form state
EditAlertDefinition.tsx Added feature flag to form context for alert editing
utils.ts Added helper functions to check max selections and determine option disabled state
utils.test.ts Added comprehensive test coverage for new helper functions
ValueSchemas.ts Added validation for 'in' operator to enforce max selection limit
ValueFieldRenderer.tsx Retrieved feature flag and passed maxSelections to autocomplete components
[Multiple Autocomplete files] Integrated max selection logic including helper text, disabled options, and select all control
constants.ts Added maxSelections property to DimensionFilterAutocompleteProps interface
.changeset/pr-13361-added-1770207290291.md Added changeset documenting the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@venkymano-akamai venkymano-akamai marked this pull request as ready for review February 5, 2026 13:04
@venkymano-akamai venkymano-akamai requested a review from a team as a code owner February 5, 2026 13:04
@venkymano-akamai
Copy link
Contributor Author

@pmakode-akamai , lets see if we can review this

@pmakode-akamai
Copy link
Contributor

pmakode-akamai commented Feb 9, 2026

@pmakode-akamai , lets see if we can review this

I think I need an alerts/metrics tag for Firewalls on DevCloud to test this PR.

@pmakode-akamai , i feel this is added and ready?

Copy link

@kmuddapo kmuddapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #15 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing865 Passing11 Skipped40m 14s

Details

Failing Tests
SpecTest
quotas-storage.spec.tsCloud Manager Cypress Tests→Quota workflow tests→Quota storage table » Quotas and quota usages display properly

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

6 participants