-
Notifications
You must be signed in to change notification settings - Fork 396
Add: [DI-29170] - Value field selection limitation in CloudPulse metrics and alerts dimension filters #13361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add: [DI-29170] - Value field selection limitation in CloudPulse metrics and alerts dimension filters #13361
Conversation
…mano-akamai/manager into value_field_dimension_filter_limit
…mano-akamai/manager into value_field_dimension_filter_limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds the ability to restrict the maximum number of selectable values in CloudPulse metrics and alerts dimension filters, controlled by a feature flag.
Changes:
- Added
maxDimensionFiltersValuesfeature flag to control selection limits - Implemented UI restrictions that disable options once the limit is reached and hide select/deselect all buttons when appropriate
- Added validation schema to enforce the maximum selection limit for the 'in' operator
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| featureFlags.ts | Added maxDimensionFiltersValues property to AclpAlerting interface |
| CloudPulseDimensionFilterRenderer.tsx | Passed feature flag value to form context for validation |
| CloudPulseDimensionFilterFields.tsx | Replaced setValue with resetField to properly reset form state |
| EditAlertDefinition.tsx | Added feature flag to form context for alert editing |
| utils.ts | Added helper functions to check max selections and determine option disabled state |
| utils.test.ts | Added comprehensive test coverage for new helper functions |
| ValueSchemas.ts | Added validation for 'in' operator to enforce max selection limit |
| ValueFieldRenderer.tsx | Retrieved feature flag and passed maxSelections to autocomplete components |
| [Multiple Autocomplete files] | Integrated max selection logic including helper text, disabled options, and select all control |
| constants.ts | Added maxSelections property to DimensionFilterAutocompleteProps interface |
| .changeset/pr-13361-added-1770207290291.md | Added changeset documenting the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...nager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterValue/utils.test.ts
Outdated
Show resolved
Hide resolved
...nager/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterValue/utils.test.ts
Outdated
Show resolved
Hide resolved
...ger/src/features/CloudPulse/Alerts/CreateAlert/Criteria/DimensionFilterValue/ValueSchemas.ts
Show resolved
Hide resolved
|
@pmakode-akamai , lets see if we can review this |
I think I need an alerts/metrics tag for @pmakode-akamai , i feel this is added and ready? |
kmuddapo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…mano-akamai/manager into value_field_dimension_filter_limit
Cloud Manager UI test results🔺 1 failing test on test run #15 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts" |
|||||||||||||||||
Description 📝
Ability to restrict the maximum selectable values in the CloudPulse metrics and alerts dimension filters.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️ Next Release date
Preview 📷
How to test 🧪
Metrics
Alerts
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅