-
Notifications
You must be signed in to change notification settings - Fork 396
Change:[DI-29624] - Use binary based formulas for bits rollup #13369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Cloud Manager UI test results🎉 866 passing tests on test run #5 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm: Is it expected that *Bps and *bps map to the same value now?
it('Kbps vs KBps', () => {
expect(convertValueToUnit(1024, 'Kbps')).toBe(1);
expect(convertValueToUnit(1024, 'KBps')).toBe(1);
});There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes...correct, we are moving towards a binary based formula
only thing is Bps is Bytes per second, bps is bit per second
Description 📝
Use binary based formulas for bits rollup in cloudpulse
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️Next Release date
Preview 📷
This is a unit rollup change, no change in UI / UX
How to test 🧪
This is a unit rollup change, no change in UI / UX
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅