Skip to content

Conversation

@venkymano-akamai
Copy link
Contributor

@venkymano-akamai venkymano-akamai commented Feb 5, 2026

Description 📝

Use binary based formulas for bits rollup in cloudpulse

Changes 🔄

  1. Change unitconversion.ts to use binary based formulas to rollup bits to Mb, Kb, Gb etc.,
  2. Fix the UT's accordingly

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Target release date 🗓️Next Release date

Preview 📷

This is a unit rollup change, no change in UI / UX

How to test 🧪

This is a unit rollup change, no change in UI / UX

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@venkymano-akamai venkymano-akamai marked this pull request as ready for review February 6, 2026 14:02
@venkymano-akamai venkymano-akamai requested a review from a team as a code owner February 6, 2026 14:02
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 866 passing tests on test run #5 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing866 Passing11 Skipped35m 48s

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm: Is it expected that *Bps and *bps map to the same value now?

  it('Kbps vs KBps', () => {
    expect(convertValueToUnit(1024, 'Kbps')).toBe(1);
    expect(convertValueToUnit(1024, 'KBps')).toBe(1);
  });

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes...correct, we are moving towards a binary based formula

only thing is Bps is Bytes per second, bps is bit per second

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

5 participants