upcoming: [UIE-10183] Added new product to marketplace #13370
Conversation
dwiley-akamai
left a comment
dwiley-akamai
left a comment
There was a problem hiding this comment.
Verification steps ✅
Code review ✅
Upcoming Features changeset needed for the manager package 🛑
| */ | ||
| const detailsMap: Record<string, ProductTabDetails> = { | ||
| 'akamai-cloud-computing': akamaiCloudComputing, | ||
| apimetrics, |
There was a problem hiding this comment.
| apimetrics, | |
| 'api-metrics': apiMetrics, |
I think we should update the key for the apimetrics product to use kebab-case ('api-metrics') so it's consistent with the other product slugs and easier to read
There was a problem hiding this comment.
We could update the product file name to match the kebab-case slug. For eg., renaming the file from apimetrics to api-metrics would keep it consistent with the other product files and make it easier to locate and read
| @@ -17,6 +18,7 @@ export interface ProductTabDetails { | |||
| */ | |||
| const detailsMap: Record<string, ProductTabDetails> = { | |||
| 'akamai-cloud-computing': akamaiCloudComputing, | |||
There was a problem hiding this comment.
| 'akamai-cloud-computing': akamaiCloudComputing, |
If this product is no longer needed or dummy, I think we should remove it from the detailsMap and the /pages directory.
| @@ -1,4 +1,5 @@ | |||
| import { akamaiCloudComputing } from './akamai-cloud-computing'; | |||
| import { apimetrics } from './apimetrics'; | |||
There was a problem hiding this comment.
| import { apimetrics } from './apimetrics'; | |
| import { apiMetrics } from './apimetrics'; |
| @@ -0,0 +1,78 @@ | |||
| /** | |||
| * Product tab details for slug apimetrics. | |||
There was a problem hiding this comment.
| * Product tab details for slug apimetrics. | |
| * Product tab details for slug api-metrics. |
There was a problem hiding this comment.
Could we remove the unused duplicate icons akamai-color-logo.svg and akamai-logo.svg from /public/assets/marketplace?
| { | ||
| id: 'akamai-cloud-computing', | ||
| name: 'Akamai Cloud Computing', | ||
| id: 'apimetrics', |
There was a problem hiding this comment.
| id: 'apimetrics', | |
| id: 'api-metrics', |
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
| "@linode/manager": Upcoming Features | ||
| --- | ||
|
|
||
| Added New Marketplace products ([#13370](https://github.com/linode/manager/pull/13370)) |
There was a problem hiding this comment.
| Added New Marketplace products ([#13370](https://github.com/linode/manager/pull/13370)) | |
| Add new Marketplace products ([#13370](https://github.com/linode/manager/pull/13370)) |
5 participants
Description 📝
Added real product received from Product Team and cleaned up the sample products. Also, added breadcrumb to details page.
Changes 🔄
Replaced sample product with real product received from Product.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
27th Feb 2026
How to test 🧪
Go to Partner referreals
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅