fix: STORIF-247 - Thoughput quota formatting fixed. #13371
+34
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchyrva-akamai
force-pushed
the
bugfix/STORIF-247
branch
from
da693a6 to
35ec98b
Compare
dchyrva-akamai
force-pushed
the
bugfix/STORIF-247
branch
from
35ec98b to
7fd15ce
Compare
skulpok-akamai
requested changes
Feb 6, 2026
packages/manager/src/features/Account/Quotas/QuotasTable/QuotasTableRow.tsx
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Review
to Changes Requested
in Cloud Manager
dchyrva-akamai
force-pushed
the
bugfix/STORIF-247
branch
3 times, most recently
from
d8c7412 to
679cecc
Compare
dchyrva-akamai
force-pushed
the
bugfix/STORIF-247
branch
from
679cecc to
f49481d
Compare
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts" |
|||||||||||||||||
skulpok-akamai
approved these changes
Feb 6, 2026
Comment on lines
+114
to
+116
| export const getQuotaMapper = (service: QuotaType) => { | ||
| return { | ||
| mapQuota(quota: Quota, usage: null | QuotaUsage): QuotaWithUsage { |
Member
There was a problem hiding this comment.
The types make it pretty clear but maybe we could improve the naming here? getQuotaMapper/ mapQuota don't give me the full picture of what the function does
Contributor
There was a problem hiding this comment.
@bnussman-akamai Do you have any proposals for a different name? This function allows for each quota service (e.g. object-storage, block-storage, etc.) to transform/adjust the quota data (like quota name in case of object-storage).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Thoughput quota formatting fixed.
Preview 📷
How to test 🧪
/quotaspage.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅