Skip to content

Conversation

@aaleksee-akamai
Copy link
Contributor

Description 📝

This PR normalizes the search value for Users table

Changes 🔄

List any change(s) relevant to the reviewer.

  • Update logic for searching
  • Cleanup

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
Screen.Recording.2026-02-04.at.11.55.57.AM.mov
Screen.Recording.2026-02-09.at.2.56.23.PM.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • use child/delegate account

Reproduction steps

(How to reproduce the issue, if applicable)

  • go to /iam/users
  • search with a query containing only digits (Ex. 123)
  • change user filter couple of times.

Verification steps

(How to verify changes)

  • Query string is not being distorted
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai self-assigned this Feb 9, 2026
@aaleksee-akamai aaleksee-akamai added the IAM Delegation Implementing the new Parent/Child delegation UI label Feb 9, 2026
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can clean up handleSearch a bit more?

  const handleSearch = (value: string) => {
    const nextQuery = value === '' ? undefined : String(value);
    navigate({
      to: '/iam/users',
      search: (prev) => ({
        ...prev,
        query: nextQuery,
        page: 1,
      }),
    });
  };

This way we don't have to set users manually. It will just inheret from the "previous" (prev) query params.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing864 Passing11 Skipped41m 43s

Details

Failing Tests
SpecTest
vpc-linodes-update.spec.tsCloud Manager Cypress Tests→VPC assign/unassign flows » can assign Linode(s) to a VPC
vpc-linodes-update.spec.tsCloud Manager Cypress Tests→VPC assign/unassign flows » can assign a Linode without auto-assigning an IPv4 to a VPC

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/vpc/vpc-linodes-update.spec.ts"

Copy link
Contributor

@mpolotsk-akamai mpolotsk-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix. Thanks!

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Feb 10, 2026
@aaleksee-akamai aaleksee-akamai merged commit e343f1f into linode:develop Feb 10, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

IAM Delegation Implementing the new Parent/Child delegation UI

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants