test: [DI-29822] - Add spec for create notification channel #13383
+292
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts" |
|||||||||||||||||
santoshp210-akamai
added
e2e
| * Verifies server error handling during channel creation. | ||
| */ | ||
| beforeEach(() => { | ||
| mockAppendFeatureFlags(flagsFactory.build()); |
Contributor
There was a problem hiding this comment.
why do you need mock the feature flags here? the tests pass w/out this statement
Contributor
There was a problem hiding this comment.
More specifically, @shnagend-akamai if you need to mock any feature flags, mock just the feature flags that you need for the test. This creates maintenance overhead where any change to the flag factory risks breaking these tests.
Edit: apologies, CC'd Ankita by mistake!
| .click(); | ||
|
|
||
| // Validate API request payload for notification channel creation | ||
| cy.wait('@createAlertChannelNew').then((interception) => { |
Contributor
There was a problem hiding this comment.
this block of code doesn't test anything in the UI, it's just testing the test code which mocks the response. the test below where you filter for the label to ensure that the new item is visible is sufficient and does this better.
dmcintyr-akamai
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR adds a new test specification (spec) relating to creating a notification channel in the Linode Manager application. It is basically work done as part of DI-29084, which is a ticket related to the notification channel feature.
Changes 🔄
Target release date 🗓️
24th Feb
Preview 📷
Include a screenshot
<img src="" />or video<video src="" />of the change.alert-notification-channel-create.spec.ts.mp4
How to test 🧪
pnpm cy:run -s "cypress/e2e/core/cloudpulse/alert-notification-channel-create.spec.ts"
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅