Skip to content

Conversation

@aaleksee-akamai
Copy link
Contributor

Description 📝

This PR fixes a pagination for Assigned Entities table

Changes 🔄

List any change(s) relevant to the reviewer.

  • Update a condition for pagination

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • use iam account
  • have more than 25 assigned entities

Reproduction steps

(How to reproduce the issue, if applicable)

  • go to /iam/users/username/entities

Verification steps

(How to verify changes)

  • Confirm the pagination is present if user has more than the 25 assigned entities
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai aaleksee-akamai requested a review from a team as a code owner February 9, 2026 16:07
Comment on lines +207 to +209
const filteredAndSortedRolesCount = React.useMemo(() => {
return filteredAndSortedRoles.length;
}, [filteredAndSortedRoles]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using useMemo here may not be necessary because filteredAndSortedRoles.length itself is not an expensive operation.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 2 failing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing864 Passing11 Skipped41m 12s

Details

Failing Tests
SpecTest
quotas-storage.spec.tsCloud Manager Cypress Tests→Quota workflow tests→Quota storage table » Quotas and quota usages display properly
search-images.spec.tsCloud Manager Cypress Tests→Search Images » creates two images and make sure they show up in the table and are searchable

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/account/quotas-storage.spec.ts,cypress/e2e/core/images/search-images.spec.ts"

@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Feb 10, 2026
@aaleksee-akamai aaleksee-akamai merged commit 89027b7 into linode:develop Feb 10, 2026
34 of 35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants