Skip to content

feat: [UIE-10535] - IAM: MaskableText component#13542

Draft
aaleksee-akamai wants to merge 2 commits intolinode:developfrom
aaleksee-akamai:UIE-10535
Draft

feat: [UIE-10535] - IAM: MaskableText component#13542
aaleksee-akamai wants to merge 2 commits intolinode:developfrom
aaleksee-akamai:UIE-10535

Conversation

@aaleksee-akamai
Copy link
Copy Markdown
Contributor

Description 📝

This PR adds a new MaskableText component for IAM, replacing the old one from the linode library.

Note: it requires importing a local build of the CDS components.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add a new component
  • Add tests

Scope 🚢

Upon production release, changes in this PR will be visible to:

  • All customers
  • Some customers (e.g. in Beta or Limited Availability)
  • No customers / Not applicable

Preview 📷

Before After
devcloud localhost
image image
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • use iam account
  • mask Sensitive Data in the /profile/preferences

Reproduction steps

(How to reproduce the issue, if applicable)

  • go to /iam/users
  • go to /iam/users/username/details

Verification steps

(How to verify changes)

  • The new MaskableText components should look the same (or close) as the old one.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All tests and CI checks are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Copy link
Copy Markdown
Contributor

@mpolotsk-akamai mpolotsk-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, looks good. The only difference is the tooltip background, which is intentional per the new Figma design. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

2 participants