upcoming: [UIE-9409] — View Shared Image Details drawer#13558
Open
dwiley-akamai wants to merge 5 commits intolinode:developfrom
Open
upcoming: [UIE-9409] — View Shared Image Details drawer#13558dwiley-akamai wants to merge 5 commits intolinode:developfrom
dwiley-akamai wants to merge 5 commits intolinode:developfrom
Conversation
…FromImageRegion() helper function
…-shared images later
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Implement the "View shared image details" drawer
Changes 🔄
Drawerfor "X" buttonScope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
TBD
Preview 📷
How to test 🧪
Prerequisites
Toggle the
Private Image Sharingflag in the CM DevTool. You can use the Legacy MSW but some fields will be missing out of the box.Verification steps
With the
Private Image Sharingflag on...Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅