upcoming: [UIE-10690] – Support ACLP-NB Metrics Integration feature flag#13563
Open
harsh-akamai wants to merge 1 commit intolinode:developfrom
Open
upcoming: [UIE-10690] – Support ACLP-NB Metrics Integration feature flag#13563harsh-akamai wants to merge 1 commit intolinode:developfrom
harsh-akamai wants to merge 1 commit intolinode:developfrom
Conversation
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #1 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||
| * but will eventually also look at account capabilities. | ||
| */ | ||
|
|
||
| export const useIsAclpNbMetricsIntegrationEnabled = () => { |
Contributor
There was a problem hiding this comment.
I don't think we need to create a new hook here since there won't be any customer tag/account capability for this project. To avoid redundant hooks, we can simply use const { aclpNbMetricsIntegration } = useFlags(); wherever this check is needed for this integration work.
pmakode-akamai
added
NodeBalancers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Create a boolean feature flag for ACLP NB Metrics Integration and support it in Cloud
Changes 🔄
aclpNbMetricsIntegrationfeature flag toggle added to our dev toolScope 🚢
Upon production release, changes in this PR will be visible to:
How to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅