upcoming: [UIE-9410] - Create Share Group: Implement the Images select table#13567
upcoming: [UIE-9410] - Create Share Group: Implement the Images select table#13567fabrice-akamai wants to merge 20 commits intolinode:developfrom
Conversation
| shareGroupInfoIcon: 'Linodes Rebuild Images-Share Group info icon', | ||
| }; | ||
|
|
||
| export const IMAGE_SELECT_TABLE_SHARE_GROUP_CREATE_PENDO_IDS = { |
…able in the create share groups page
dwiley-akamai
left a comment
There was a problem hiding this comment.
The Create Share Group API requires each image in the payload to have a non-empty description, otherwise it returns a 400 Error code.
Per the API spec, shouldn't that field be optional? If the API isn't treating it as such, we should check with them to see if the spec is inaccurate or if it's an API bug
packages/manager/.changeset/pr-13567-upcoming-features-1775674749388.md
Outdated
Show resolved
Hide resolved
…749388.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
dwiley-akamai
left a comment
There was a problem hiding this comment.
Verification steps ✅
Code review ✅
Approved pending Pendo-related tweaks
packages/manager/src/features/Images/ImagesLanding/v2/constants.ts
Outdated
Show resolved
Hide resolved
...eatures/Images/ImagesLanding/v2/ShareGroups/ShareGroupsCreate/ShareGroupsCreateContainer.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
thanks @fabrice-akamai!!
Just a couple of things related to the ImageSelectTable (non-blocking). These might be unrelated and could be worth a separate ticket:
- The zebra striping doesn't seem to work for the Selection Table when Table striping is enabled, is this expected in this case?
- Pagination is still visible even when there are only a few records (fewer than or equal to the minimum available page size, which is
10here). As discussed for the other table before, should the same behavior be applied here? I believe it should be consistent, but it's worth confirming.
Verification steps ✅ Approval pending resolution of the loading button state comment + there appears to be a merge conflict that needs to be resolved.
...ger/src/features/Images/ImagesLanding/v2/ShareGroups/ShareGroupsCreate/ShareGroupsCreate.tsx
Show resolved
Hide resolved
@dwiley-akamai, looping you in since these issues are related to the |
@fabrice-akamai Probably a separate ticket is better |
Cloud Manager UI test results🔺 1 failing test on test run #11 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts" |
|||||||||||||||||


Description 📝
This PR adds the Images table to the Create Share Group page, enabling unrestricted users to select the images to include in a new share group.
Changes 🔄
List any change(s) relevant to the reviewer.
Scope 🚢
Upon production release, changes in this PR will be visible to:
Preview 📷
Screen.Recording.2026-04-08.at.1.28.31.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅